Use grid module for StandardLayout#15428
Merged
Merged
Conversation
frederickobrien
added
the
maintenance
frederickobrien
force-pushed
the
grid-api-for-standard-layout
branch
from
c8e046d to
b0f4bf5
Compare
frederickobrien
changed the title
StandardLayoutStandardLayout
frederickobrien
force-pushed
the
grid-api-for-standard-layout
branch
from
bb14535 to
b752a6f
Compare
frederickobrien
changed the title
StandardLayoutStandardLayout, introduce vertical rules
frederickobrien
force-pushed
the
grid-api-for-standard-layout
branch
3 times, most recently
from
ab9a1c2 to
0646448
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
frederickobrien
force-pushed
the
grid-api-for-standard-layout
branch
from
81a91f8 to
e67e85c
Compare
domlander
reviewed
Mar 4, 2026
frederickobrien
force-pushed
the
grid-api-for-standard-layout
branch
3 times, most recently
from
2357924 to
cf39bf7
Compare
frederickobrien
force-pushed
the
grid-api-for-standard-layout
branch
2 times, most recently
from
cbee04b to
12ef9bb
Compare
github-actions
Bot
removed
the
run_chromatic
frederickobrien
force-pushed
the
grid-api-for-standard-layout
branch
2 times, most recently
from
60a6347 to
31dca25
Compare
github-actions
Bot
removed
the
run_chromatic
This was referenced Jun 3, 2026
JamieB-gu
approved these changes
Jun 10, 2026
JamieB-gu
left a comment
JamieB-gu
left a comment
Contributor
There was a problem hiding this comment.
Great work @frederickobrien ! A few comments/questions, I don't think anything blocking.
I assume this will need reconciling with the changes in #15951?
| } as const; | ||
|
|
||
| // ----- Types ----- // | ||
| type ColumnPreset = keyof typeof grid.column; |
Contributor
There was a problem hiding this comment.
Where is this export used?
Contributor
Author
Co-Authored-By: Jamie B <53781962+JamieB-gu@users.noreply.github.com>
|
Seen on PROD (merged by @frederickobrien 25 minutes and 42 seconds ago) Please check your changes! |
Member
|
Spectacular work Fred! Just documenting some of the issues after the release of this, so we have a checklist for future grid updates: Affiliate disclaimer: Interscroller ads, due to a z-index issue: Lightbox layout: Where possible we should improve our testing so we catch any regressions earlier. |
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change and why?
This refactors the
StandardLayoutto use thegridmodule, which itself implements the Guardian Grid, hopefully making it easier to reason with and style. This is with one eye on header standardisation work by @guardian/articles-and-publishing as well as a potential revamp of the interactive layout (see #15358).As part of this I've had a stab at introducing
verticalRulesto thegridmodule, allowing for lines to be added if they're wanted. After a few iterations I've made this something that's pure CSS and baked into the grid module itself.verticalRulesadds outer borders, whileverticalRules({ centre: true })adds an additional one to the left hand side of the centre column.While there are ongoing questions about how best to abstract the config I think the overall outcome here is good, with the grid module and configuration options being something that could be applied to other layouts going forward.
A glimpse of the sorts of things this could enable: #15509
I'm probably missing subtler differences but I think with these changes the following layouts could be (easily in some cases) absorbed into
StandardLayout, with thousands of lines of duplicate code lost in the process:ShowcaseLayout(Move ShowcaseLayout to grid #16119)AudioLayout(Move AudioLayout to grid #16133)CommentLayoutPictureLayout(Move PictureLayout to grid #16251)ImmersiveLayout(Revamped immersive layout(s) #15922)A few open questions:
maxWidthwrappers? (I think yes)Context
Examples of different layouts
Standard
Showcase
Screenshots